wire: check TXID length before creating outpoint #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Aug 15, 2024
Pull Request Test Coverage Report for Build 10394619593Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chainhash.NewHashFromStrwill zero-pad the given string if it's smaller than 32 bytes / 64 hex chars.That's fine, but when creating an OutPoint from a string, the TXID part of the string must be exactly 64 hex chars to (possibly) be a valid TXID. Right now,
NewOutPointFromStringaccepts a TXID of less than 64 chars, and will end up padding the end with 0's.This PR rejects incorrectly-sized TXID strings in
NewOutPointFromString.